Skip to content

Fix for shapefiles in the cloud? #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ldecicco-USGS wants to merge 1 commit into from
Closed

Fix for shapefiles in the cloud? #340

ldecicco-USGS wants to merge 1 commit into from

Conversation

@ldecicco-USGS
Copy link
Contributor

@ldecicco-USGS ldecicco-USGS commented Dec 22, 2025

The cuid and key are needed for downloads, and seem to get lost in get_facet_files.

I'm not confident on how/if this would break other things. I got 2 failed tests, but they might be unrelated (a 404 on an item).

This is what was failing (and now works):

item <- sbtools::item_get("69330512d4be02765ea81805")
shapefiles <- item |> 
	sbtools::item_list_files() |> 
	dplyr::filter(facet == 'SWFL_SurveyAreas_2025') |> 
	dplyr::pull(fname)
fs::dir_create(path = fs::path_wd("sb_download"))
sbtools::item_file_download(sb_id = item,
					     names = shapefiles,
					     destinations = fs::path_wd("sb_download", shapefiles),
					     fetch_cloud_urls = TRUE)

@dblodgett-usgs
Copy link
Collaborator

dblodgett-usgs commented Dec 23, 2025

Thanks Laura -- I'm on leave till January 5th and will look into what's up here when I'm back.

@dblodgett-usgs
Copy link
Collaborator

dblodgett-usgs commented Jan 8, 2026

I used more or less this pattern in a commit I have incoming. Thanks for the head start @ldecicco-USGS

@dblodgett-usgs dblodgett-usgs mentioned this pull request Jan 8, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ldecicco-USGS @dblodgett-usgs